Multiple dialogue boxes can be opened forcing users to refresh before being able to continue using the panel

Version details

PhantomBot Version: 3.0.0 (Revision: fcc08b51)
Operating System: Linux Ubuntu 18.04.2 LTS
Java Version: 1.8.0_201-b09
Browser Version: Google Chome x64 - v75.0.3770.90
Stock PhantomBot: Yes

Issue Details

Although a minor issue, the resulting issue will force users to have to refresh before they can continue to use the panel.
Most buttons that open a dialogue with a dimmed background div don’t lose focus allowing multiple dialogues to be opened using the Enter key. After closing n-1 dialogues, the final dialogue self closes, but only one out of n dimmed divs are removed.

Steps to reproduce

  1. Navigate to your PhantomBot web panel
  2. Sign-in
  3. In the MAIN NAVIGATION sidebar, click Moderation
  4. Click Filters
  5. Click the cogwheel on the Links Filter box
  6. Press your Enter key
  7. Click the x or Cancel button

Step 6 will cause a second dialogue will be overlayed on the first.
Step 7 will cause both dialogue boxes to disappear, but one dimmed background div remains, preventing any further actions taking place.

Step 6 can be repeated n times but step 7 will then need to be repeated n - 1 times. The - 1 is due to the final dialogue box self-closing. However, step 7 only removes a single dimmed div no matter what number n is.

I’ve been able to reproduce this on all buttons I’ve tried that opens a dimmed dialogue box.

Fixed in PR #2164

Thanks for reporting

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.